gtkdnd: Disconnect GdkDragContext signals on gtk_drag_source_info_free()
authorCarlos Garnacho <carlosg@gnome.org>
Wed, 20 Jan 2016 17:53:03 +0000 (18:53 +0100)
committerCarlos Garnacho <carlosg@gnome.org>
Wed, 20 Jan 2016 17:53:03 +0000 (18:53 +0100)
Otherwise it may still be tricked into emitting further signals at a
time we've already destroyed the GtkDragSourceInfo passed as callback
user data.

gtk/gtkdnd.c

index 6c60fed6c7ede3ce0a1670396945c776e788d2f7..b31b5c5336f0c180737917b6e0483ee5589e01a4 100644 (file)
@@ -3206,6 +3206,19 @@ gtk_drag_source_info_free (GtkDragSourceInfo *info)
 static void
 gtk_drag_source_info_destroy (GtkDragSourceInfo *info)
 {
+  g_signal_handlers_disconnect_by_func (info->context,
+                                        gtk_drag_context_drop_performed_cb,
+                                        info);
+  g_signal_handlers_disconnect_by_func (info->context,
+                                        gtk_drag_context_dnd_finished_cb,
+                                        info);
+  g_signal_handlers_disconnect_by_func (info->context,
+                                        gtk_drag_context_cancel_cb,
+                                        info);
+  g_signal_handlers_disconnect_by_func (info->context,
+                                        gtk_drag_context_action_cb,
+                                        info);
+
   g_signal_handlers_disconnect_by_func (info->ipc_widget,
                                         gtk_drag_grab_broken_event_cb,
                                         info);